-
Notifications
You must be signed in to change notification settings - Fork 49.4k
Add a section at 'jsx-in-depth' talking about namespaced components #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/docs/02.1-jsx-in-depth.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"This feature is available in v0.11 and above."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
Hi guys, I don't want to bother you, but what do you think about the PR? If there is something that I have to change or improve, please tell me. |
Hey, really sorry for letting this sit here. We got caught up in the push for 0.12 and dropped the ball. This file has been changed a bit since you wrote this, so it'll need to be rebased but otherwise let's do it. |
* master: (113 commits) Remove esprima-fb and use Syntax from jstransform Update React.renderToString argument type in docs [traverseAllChildren] fix out-of-scope var use. Use double quote for transformed `displayName` and `data-*` Remove unrelated comment Fix typo in If/Else JSX doc. Cleanup a couple unused variables Use dump cache and remove factory from ReactElement-test Update deprecated propTypes Bring in jsfiddle integration script, add harmony Extending period in which click events are ignored React.renderComponent --> React.render Followup fix for React.PropTypes.node Add comma for readability in tutorial Drop internal uses of .type on the class Drop Legacy Factories Around Classes Drop ReactDOM from internal DOM extensions Added comma to increase readability. Add 0.12 starter kit Change the date and the link url to match the proper roundup ... Conflicts: docs/docs/02.1-jsx-in-depth.md
@zpao No trouble, I think that you had a lot of job to make the v0.12, was a pretty good job. So, I made some changes to adapt things to v0.12. I think that everythink is ok ;) |
docs/docs/02.1-jsx-in-depth.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, thank you @aackerman. I didn't see that.
Add a section at 'jsx-in-depth' talking about namespaced components
Add a section at 'jsx-in-depth' talking about namespaced components
Hi guys,
A feature that I like so mush in JSX and use in a lot of situations is the namespaced component that was created in version 0.11. So, I saw that have just a simple line of text in a blog post talking about it. I think that is a good feature to have in the section JSX in Depth of the website.
Well, I created something short to explain that this feature can be used and avoid many boring things.
😄