Pin CI to Node 14 #22665
Merged
Pin CI to Node 14 #22665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI starting running Node 16, which breaks some of our tests because the error message text for undefined property access has changed. We should pin to Node 14 until we are able to update the messages.
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 6c7ef3f...a5b0cff Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
KamranAsif
pushed a commit
to KamranAsif/react
that referenced
this pull request
Nov 4, 2021
CI starting running Node 16, which breaks some of our tests because the error message text for undefined property access has changed. We should pin to Node 14 until we are able to update the messages.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Jan 19, 2022
Cherry-picking this from later in the sequence. Pinning to Node 14 was necessary because the error message for undefined property access changed in later versions, and some of our tests assert on the old format.
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
CI starting running Node 16, which breaks some of our tests because the error message text for undefined property access has changed. We should pin to Node 14 until we are able to update the messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI starting running Node 16, which breaks some of our tests because the error message text for undefined property access has changed.
We should pin to Node 14 until we are able to update the messages.