Skip to content

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Mar 25, 2021

Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 25, 2021
@sizebot
Copy link

sizebot commented Mar 25, 2021

Comparing: 4a99c5c...2a8211f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.91 kB 122.74 kB = 39.52 kB 39.43 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.43 kB 129.26 kB = 41.60 kB 41.52 kB
facebook-www/ReactDOM-prod.classic.js = 407.23 kB 406.30 kB = 75.65 kB 75.48 kB
facebook-www/ReactDOM-prod.modern.js = 395.49 kB 394.56 kB = 73.70 kB 73.56 kB
facebook-www/ReactDOMForked-prod.classic.js = 407.23 kB 406.31 kB = 75.66 kB 75.48 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.50 kB 0.46 kB = 0.33 kB 0.29 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.50 kB 0.46 kB = 0.33 kB 0.29 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js = 1.90 kB 1.06 kB = 0.83 kB 0.45 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js = 1.90 kB 1.06 kB = 0.83 kB 0.45 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 92.06 kB 91.86 kB = 28.51 kB 28.43 kB
facebook-www/ReactDOMForked-profiling.classic.js = 428.98 kB 428.07 kB = 79.24 kB 79.09 kB
facebook-www/ReactDOM-profiling.classic.js = 428.98 kB 428.06 kB = 79.23 kB 79.08 kB
facebook-www/ReactDOMForked-dev.classic.js = 1,061.52 kB 1,059.21 kB = 235.86 kB 235.22 kB
facebook-www/ReactDOM-dev.classic.js = 1,061.93 kB 1,059.61 kB = 236.02 kB 235.28 kB
facebook-www/ReactDOMForked-profiling.modern.js = 417.20 kB 416.29 kB = 77.35 kB 77.21 kB
facebook-www/ReactDOM-profiling.modern.js = 417.20 kB 416.28 kB = 77.35 kB 77.21 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.min.js = 86.68 kB 86.49 kB = 26.87 kB 26.79 kB
facebook-www/ReactDOMForked-dev.modern.js = 1,035.27 kB 1,032.96 kB = 230.39 kB 229.81 kB
facebook-www/ReactDOM-dev.modern.js = 1,035.68 kB 1,033.36 kB = 230.54 kB 229.86 kB
facebook-www/ReactDOMForked-prod.classic.js = 407.23 kB 406.31 kB = 75.66 kB 75.48 kB
facebook-www/ReactDOM-prod.classic.js = 407.23 kB 406.30 kB = 75.65 kB 75.48 kB
facebook-www/ReactDOMForked-prod.modern.js = 395.49 kB 394.57 kB = 73.71 kB 73.57 kB
facebook-www/ReactDOMTesting-prod.classic.js = 399.27 kB 398.35 kB = 75.62 kB 75.50 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 82.10 kB 81.91 kB = 25.63 kB 25.55 kB
facebook-www/ReactDOM-prod.modern.js = 395.49 kB 394.56 kB = 73.70 kB 73.56 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,009.95 kB 1,007.57 kB = 220.25 kB 219.74 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 82.25 kB 82.06 kB = 25.96 kB 25.91 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 960.81 kB 958.53 kB = 217.57 kB 216.94 kB
facebook-www/ReactDOMTesting-dev.classic.js = 974.59 kB 972.27 kB = 219.13 kB 218.58 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.min.js = 79.73 kB 79.54 kB = 24.87 kB 24.80 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 81.74 kB 81.54 kB = 25.46 kB 25.38 kB
facebook-www/ReactDOMTesting-prod.modern.js = 385.48 kB 384.56 kB = 73.30 kB 73.18 kB
oss-stable/react-test-renderer/umd/react-test-renderer.production.min.js = 79.89 kB 79.70 kB = 25.16 kB 25.12 kB
facebook-www/ReactDOMTesting-dev.modern.js = 945.52 kB 943.20 kB = 212.81 kB 212.33 kB
oss-stable/react-art/cjs/react-art.production.min.js = 76.89 kB 76.70 kB = 24.00 kB 23.94 kB
oss-stable/react-dom/umd/react-dom.development.js = 955.83 kB 953.45 kB = 210.00 kB 209.45 kB
oss-stable/react-dom/cjs/react-dom.development.js = 909.31 kB 907.03 kB = 207.46 kB 206.78 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 98.44 kB 98.16 kB = 30.47 kB 30.39 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js = 91.01 kB 90.73 kB = 28.16 kB 28.08 kB
react-native/implementations/ReactNativeRenderer-prod.js = 279.83 kB 278.80 kB = 50.13 kB 49.98 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 279.78 kB 278.74 kB = 50.10 kB 49.95 kB
react-native/implementations/ReactFabric-prod.js = 272.61 kB 271.57 kB = 48.70 kB 48.54 kB
react-native/implementations/ReactFabric-prod.fb.js = 272.56 kB 271.52 kB = 48.68 kB 48.52 kB
oss-experimental/react-art/umd/react-art.development.js = 740.51 kB 737.36 kB = 157.55 kB 156.90 kB
facebook-www/ReactART-prod.classic.js = 262.77 kB 261.65 kB = 46.76 kB 46.65 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 239.79 kB 238.75 kB = 44.00 kB 43.84 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 695.95 kB 692.90 kB = 148.97 kB 148.42 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 716.28 kB 713.14 kB = 155.51 kB 154.74 kB
facebook-www/ReactART-prod.modern.js = 255.40 kB 254.28 kB = 45.53 kB 45.40 kB
react-native/implementations/ReactNativeRenderer-dev.js = 710.71 kB 707.57 kB = 154.56 kB 153.86 kB
facebook-www/ReactART-dev.classic.js = 706.06 kB 702.94 kB = 150.70 kB 150.11 kB
facebook-www/ReactART-dev.modern.js = 695.77 kB 692.64 kB = 148.62 kB 147.97 kB
react-native/implementations/ReactFabric-dev.fb.js = 697.86 kB 694.71 kB = 150.83 kB 150.15 kB
oss-stable/react-art/umd/react-art.development.js = 696.58 kB 693.43 kB = 148.89 kB 148.22 kB
react-native/implementations/ReactFabric-dev.js = 692.28 kB 689.14 kB = 149.91 kB 149.25 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 651.49 kB 648.44 kB = 139.73 kB 139.40 kB
oss-experimental/react-art/cjs/react-art.development.js = 637.56 kB 634.51 kB = 139.23 kB 138.59 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 652.66 kB 649.50 kB = 138.13 kB 137.57 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 621.57 kB 618.52 kB = 136.48 kB 135.96 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 292.54 kB 291.09 kB = 52.52 kB 52.37 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 292.48 kB 291.03 kB = 52.49 kB 52.34 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js = 635.89 kB 632.73 kB = 134.74 kB 134.18 kB
facebook-www/ReactTestRenderer-dev.modern.js = 629.27 kB 626.14 kB = 135.65 kB 135.08 kB
facebook-www/ReactTestRenderer-dev.classic.js = 629.25 kB 626.12 kB = 135.65 kB 135.07 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 605.64 kB 602.59 kB = 133.16 kB 132.63 kB
react-native/implementations/ReactFabric-profiling.js = 285.34 kB 283.89 kB = 51.06 kB 50.89 kB
react-native/implementations/ReactFabric-profiling.fb.js = 285.28 kB 283.83 kB = 51.04 kB 50.86 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 616.56 kB 613.42 kB = 134.14 kB 133.46 kB
oss-stable/react-art/cjs/react-art.development.js = 595.77 kB 592.72 kB = 130.82 kB 130.21 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 252.38 kB 250.92 kB = 46.31 kB 46.16 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.50 kB 0.46 kB = 0.33 kB 0.29 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.production.min.js = 0.50 kB 0.46 kB = 0.33 kB 0.29 kB
oss-experimental/react-reconciler/cjs/react-reconciler-constants.development.js = 1.90 kB 1.06 kB = 0.83 kB 0.45 kB
oss-stable/react-reconciler/cjs/react-reconciler-constants.development.js = 1.90 kB 1.06 kB = 0.83 kB 0.45 kB

Generated by 🚫 dangerJS against 2a8211f

@acdlite acdlite force-pushed the use-lane-to-track-root branch from d37837b to 09d83e9 Compare March 25, 2021 05:46
@acdlite acdlite marked this pull request as draft March 25, 2021 05:47
@acdlite acdlite mentioned this pull request Mar 25, 2021
6 tasks
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
@acdlite acdlite force-pushed the use-lane-to-track-root branch from 09d83e9 to 48470f5 Compare March 25, 2021 16:38
@acdlite acdlite requested a review from rickhanlonii March 25, 2021 16:38
@acdlite acdlite marked this pull request as ready for review March 25, 2021 16:38
@acdlite acdlite force-pushed the use-lane-to-track-root branch from 48470f5 to 2a8211f Compare March 25, 2021 16:45
@acdlite acdlite merged commit dcd1304 into facebook:master Mar 28, 2021
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Apr 6, 2021
Summary:
This sync includes the following changes:
- **[c9aab1c9d](facebook/react@c9aab1c9d )**: [email protected] //<Dan Abramov>//
- **[516b76b9a](facebook/react@516b76b9a )**: [Fast Refresh] Support callthrough HOCs ([#21104](facebook/react#21104)) //<Dan Abramov>//
- **[0853aab74](facebook/react@0853aab74 )**: Log all errors to console.error by default ([#21130](facebook/react#21130)) //<Sebastian Markbåge>//
- **[d1294c9d4](facebook/react@d1294c9d4 )**: Add global onError handler ([#21129](facebook/react#21129)) //<Sebastian Markbåge>//
- **[64983aab5](facebook/react@64983aab5 )**: Remove redundant setUpdatePriority call ([#21127](facebook/react#21127)) //<Andrew Clark>//
- **[634cc52e6](facebook/react@634cc52e6 )**: Delete dead variable: currentEventWipLanes ([#21123](facebook/react#21123)) //<Andrew Clark>//
- **[1102224bb](facebook/react@1102224bb )**: Fix: flushSync changes priority inside effect ([#21122](facebook/react#21122)) //<Andrew Clark>//
- **[dbe98a5aa](facebook/react@dbe98a5aa )**: Move sync task queue to its own module ([#21109](facebook/react#21109)) //<Andrew Clark>//
- **[3ba5c8737](facebook/react@3ba5c8737 )**: Remove Scheduler indirection ([#21107](facebook/react#21107)) //<Andrew Clark>//
- **[46b68eaf6](facebook/react@46b68eaf6 )**: Delete LanePriority type ([#21090](facebook/react#21090)) //<Andrew Clark>//
- **[dcd13045e](facebook/react@dcd13045e )**: Use Lane to track root callback priority ([#21089](facebook/react#21089)) //<Andrew Clark>//
- **[5f21a9fca](facebook/react@5f21a9fca )**: Clean up host pointers in level 2 of clean-up flag ([#21112](facebook/react#21112)) //<Andrew Clark>//
- **[32d6f39ed](facebook/react@32d6f39ed )**: [Fizz] Support special HTML/SVG/MathML tags to suspend ([#21113](facebook/react#21113)) //<Sebastian Markbåge>//
- **[a77dd13ed](facebook/react@a77dd13ed )**: Delete enableDiscreteEventFlushingChange ([#21110](facebook/react#21110)) //<Andrew Clark>//
- **[048ee4c0c](facebook/react@048ee4c0c )**: Use `act` in fuzz tester to flush expired work ([#21108](facebook/react#21108)) //<Andrew Clark>//
- **[556644e23](facebook/react@556644e23 )**: Fix plurals ([#21106](facebook/react#21106)) //<Sebastian Markbåge>//
- **[8b741437b](facebook/react@8b741437b )**: Rename SuspendedWork to Task ([#21105](facebook/react#21105)) //<Sebastian Markbåge>//
- **[38a1aedb4](facebook/react@38a1aedb4 )**: [Fizz] Add FormatContext and Refactor Work ([#21103](facebook/react#21103)) //<Sebastian Markbåge>//
- **[1b7e471b9](facebook/react@1b7e471b9 )**: React Native New Architecture: Support passing nativeViewTag to getInspectorDataForViewAtPoint callback, for React DevTools compat ([#21080](facebook/react#21080)) //<Joshua Gross>//
- **[4a99c5c3a](facebook/react@4a99c5c3a )**: Use highest priority lane to detect interruptions ([#21088](facebook/react#21088)) //<Andrew Clark>//
- **[77be52729](facebook/react@77be52729 )**: Remove LanePriority from computeExpirationTime ([#21087](facebook/react#21087)) //<Andrew Clark>//
- **[3221e8fba](facebook/react@3221e8fba )**: Remove LanePriority from getBumpedLaneForHydration ([#21086](facebook/react#21086)) //<Andrew Clark>//
- **[05ec0d764](facebook/react@05ec0d764 )**: Entangled expired lanes with SyncLane ([#21083](facebook/react#21083)) //<Andrew Clark>//
- **[03ede83d2](facebook/react@03ede83d2 )**: Use EventPriority to track update priority ([#21082](facebook/react#21082)) //<Andrew Clark>//
- **[a63f0953b](facebook/react@a63f0953b )**: Delete SyncBatchedLane ([#21061](facebook/react#21061)) //<Ricky>//
- **[fa868d6be](facebook/react@fa868d6be )**: Make opaque EventPriority type a Lane internally ([#21065](facebook/react#21065)) //<Andrew Clark>//
- **[eb58c3909](facebook/react@eb58c3909 )**: react-hooks/exhaustive-deps: Handle optional chained methods as dependency ([#20204](facebook/react#20204)) ([#20247](facebook/react#20247)) //<Ari Perkkiö>//
- **[7b84dbd16](facebook/react@7b84dbd16 )**: Fail build on deep requires in npm packages ([#21063](facebook/react#21063)) //<Dan Abramov>//
- **[2c9d8efc8](facebook/react@2c9d8efc8 )**: Add react-reconciler/constants entry point ([#21062](facebook/react#21062)) //<Dan Abramov>//
- **[d0eaf7829](facebook/react@d0eaf7829 )**: Move priorities to separate import to break cycle ([#21060](facebook/react#21060)) //<Andrew Clark>//
- **[435cff986](facebook/react@435cff986 )**: [Fizz] Expose callbacks in options for when various stages of the content is done ([#21056](facebook/react#21056)) //<Sebastian Markbåge>//
- **[25bfa287f](facebook/react@25bfa287f )**: [Experiment] Add feature flag for more aggressive memory clean-up of deleted fiber trees ([#21039](facebook/react#21039)) //<Benoit Girard>//
- **[8fe7810e7](facebook/react@8fe7810e7 )**: Remove already completed comment ([#21054](facebook/react#21054)) //<Sebastian Markbåge>//
- **[6c3202b1e](facebook/react@6c3202b1e )**: [Fizz] Use identifierPrefix to avoid conflicts within the same response ([#21037](facebook/react#21037)) //<Sebastian Markbåge>//
- **[dcdf8de7e](facebook/react@dcdf8de7e )**: Remove discrete lanes and priorities ([#21040](facebook/react#21040)) //<Andrew Clark>//
- **[ca99ae97b](facebook/react@ca99ae97b )**: Replace some flushExpired callsites ([#20975](facebook/react#20975)) //<Ricky>//
- **[1fafac002](facebook/react@1fafac002 )**: Use SyncLane for discrete event hydration ([#21038](facebook/react#21038)) //<Andrew Clark>//

Changelog:
[General][Changed] - React Native sync for revisions 6d3ecb7...c9aab1c

jest_e2e[run_all_tests]

Reviewed By: JoshuaGross

Differential Revision: D27436763

fbshipit-source-id: da79a41e26bffdcdacd293178062edf098e9b58a
acdlite added a commit to acdlite/react that referenced this pull request Apr 11, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 13, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 16, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 16, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 19, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 23, 2021
This reverts commit 07c469c.

Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 23, 2021
This reverts commit 07c469c.

Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
acdlite added a commit to acdlite/react that referenced this pull request Apr 28, 2021
This reverts commit 07c469c.

Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Instead of LanePriority.

I'm removing all uses of LanePriority so I can delete it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants