Skip to content

[devtools] Add support for React Scope symbol/number #16893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 25, 2019

This adds support for displaying Scope for the fiber type rather than it being empty in dev tools. Note: scopes are an experimental feature that we're using only internally at FB. I also got rid of the old React Flare symbols that we no longer use anywhere.

@sizebot
Copy link

sizebot commented Sep 25, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 89ea3e3

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dominic.

@trueadm trueadm merged commit 57bf275 into facebook:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants