Skip to content

[Scheduler][www] Put profiling feature behind flag #16757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Sep 11, 2019

Our infra currently doesn't support loading a separate profiling build of Scheduler. Until that's fixed, the recommendation is to load a single build and gate the profiling feature behind a flag.

Alternative to #16659

Our infra currently doesn't support loading a separate profiling
build of Scheduler. Until that's fixed, the recommendation is to load
a single build and gate the profiling feature behind a flag.

Alternative to facebook#16659
@acdlite acdlite force-pushed the scheduler-www-profiling-flag branch from 995266d to 752f223 Compare September 11, 2019 20:14
@sizebot
Copy link

sizebot commented Sep 11, 2019

Details of bundled changes.

Comparing: 8f03109...752f223

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-tracing.profiling.min.js 0.0% +0.3% 3.25 KB 3.25 KB 991 B 994 B NODE_PROFILING
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.73 KB 4.73 KB 1.98 KB 1.98 KB UMD_PROD
Scheduler-dev.js +0.3% +0.2% 29.62 KB 29.7 KB 7.52 KB 7.54 KB FB_WWW_DEV
Scheduler-profiling.js +3.7% +2.3% 16.24 KB 16.84 KB 3.76 KB 3.85 KB FB_WWW_PROFILING
scheduler-tracing.development.js 0.0% +0.1% 11.72 KB 11.72 KB 3.03 KB 3.03 KB NODE_DEV
scheduler-tracing.production.min.js 0.0% 🔺+0.3% 728 B 728 B 383 B 384 B NODE_PROD
scheduler-unstable_mock.development.js 0.0% 0.0% 21.93 KB 21.93 KB 5.07 KB 5.07 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.72 KB 4.72 KB 1.92 KB 1.92 KB NODE_PROD
SchedulerMock-dev.js +0.4% +0.3% 22.25 KB 22.33 KB 5.15 KB 5.17 KB FB_WWW_DEV
scheduler.development.js 0.0% 0.0% 29.16 KB 29.16 KB 7.43 KB 7.43 KB NODE_DEV
scheduler.production.min.js 0.0% 0.0% 5 KB 5 KB 2 KB 2 KB NODE_PROD

Generated by 🚫 dangerJS against 752f223

@acdlite acdlite merged commit 0a2215c into facebook:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants