Skip to content

Correct link for troubleshooting react-dev-tools (#16690) #16708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2019

Conversation

liady
Copy link
Contributor

@liady liady commented Sep 9, 2019

As pointed out in #16690 - the link for 'React Tab Doesn't Show Up' points to the empty README.MD.
This points it to that section in the v3 version README.MD - until an updated section will be added to the new dev-tools.

As pointed out in facebook#16690 - the link for 'React Tab Doesn't Show Up' points to the empty README.MD.
This points it to that section in the v3 version README.MD - until an updated section will be added to the new dev-tools.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@sizebot
Copy link

sizebot commented Sep 9, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 70bc10f

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for the PR, but like I mentioned on the issue originally- the link should point to this repo (https://github.com/facebook/react/tree/master/packages/react-devtools) as the new DevTools lives here. Linking to the old one would probably just cause confusion.

Seems like maybe we need to add a troubleshooting section to the README in this repo. Interested in copying that over?

Add the troubleshooting section to the react dev tools readme
After adding the troubleshooting section to the readme - this will point to the correct place
@liady
Copy link
Contributor Author

liady commented Sep 10, 2019

@bvaughn Hi,
I now added the section to the README file (updated the screenshot as well), and fixed the link to point there.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@bvaughn bvaughn merged commit c317fc2 into facebook:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants