Skip to content

Fix issues with the new fork plugin #11723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2017
Merged

Fix issues with the new fork plugin #11723

merged 1 commit into from
Nov 30, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 30, 2017

Found a few issues:

  • Some Node versions crash when null character gets passed to path utils. Fixing this by ignoring Rollup internal path identifiers that start with it.
  • require.resolve() only supports the paths option since Node 8.9.0. So I'm adding another way to do it for older Nodes based on what ESLint did.

trueadm
trueadm approved these changes Nov 30, 2017
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaearon gaearon merged commit 060581b into facebook:master Nov 30, 2017
@snyk-bot snyk-bot mentioned this pull request Dec 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 23, 2023
Open
@CVSpook CVSpook mentioned this pull request May 24, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Jul 4, 2023
Open
@jackromo888 jackromo888 mentioned this pull request Jul 5, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Oct 1, 2023
Open
@xotik33 xotik33 mentioned this pull request Oct 2, 2023
Open
@CVSpook CVSpook mentioned this pull request Oct 2, 2023
Open
@DevProp DevProp mentioned this pull request Oct 11, 2023
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Nov 26, 2023
Open
@DevProp DevProp mentioned this pull request Nov 27, 2023
Open
@xotik33 xotik33 mentioned this pull request Nov 28, 2023
Open
@CVSpook CVSpook mentioned this pull request Nov 30, 2023
Open
@DevProp DevProp mentioned this pull request Dec 15, 2023
Open
This was referenced Dec 30, 2023
Open
Open
@DevProp DevProp mentioned this pull request Jan 1, 2024
Open
@xotik33 xotik33 mentioned this pull request Jan 9, 2024
Open
@DevProp DevProp mentioned this pull request Jan 9, 2024
Open
@CVSpook CVSpook mentioned this pull request Jan 9, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Jan 9, 2024
Open
@CVSpook CVSpook mentioned this pull request Jan 30, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Feb 11, 2024
Open
@CVSpook CVSpook mentioned this pull request Feb 11, 2024
Open
@xotik33 xotik33 mentioned this pull request Feb 12, 2024
Open
@DevProp DevProp mentioned this pull request Feb 12, 2024
Open
@xotik33 xotik33 mentioned this pull request Mar 22, 2024
Open
@CVSpook CVSpook mentioned this pull request Mar 22, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request Mar 22, 2024
Open
@DevProp DevProp mentioned this pull request Mar 22, 2024
Open
This was referenced Apr 5, 2024
Open
Open
@DevProp DevProp mentioned this pull request May 13, 2024
Open
@CVSpook CVSpook mentioned this pull request May 13, 2024
Open
@AlexanderGrovnes AlexanderGrovnes mentioned this pull request May 13, 2024
Open
@xotik33 xotik33 mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaearon @trueadm