Change DEV-only invariants to be warnings #11630
Merged
+69
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdlite
approved these changes
Nov 22, 2017
raphamorim
pushed a commit
to raphamorim/react
that referenced
this pull request
Nov 27, 2017
* Change DEV-only invariant about instance.state type to a warning * Change DEV-only invariant childContextTypes check to a warning
Ethan-Arrowood
pushed a commit
to Ethan-Arrowood/react
that referenced
this pull request
Dec 8, 2017
* Change DEV-only invariant about instance.state type to a warning * Change DEV-only invariant childContextTypes check to a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11618.
It's confusing to have two different code paths due to throwing in DEV but not in PROD. We try to avoid such cases.
I found these two as I was working on #11616.
They were introduced accidentally in 4d81744. In the past they would always run.
I thought about moving them out of the
__DEV__block but then figured there's no real need to run those extra checks in production. (We didn't for a few months anyway.) In particular it's nice to not runisArraychecks for every single state object.So we might as well turn them into warnings and keep them DEV-only.
Note: if we merge this, we’ll need to enable these warnings on next sync.