Skip to content

Commit 8241424

Browse files
committed
Update base for Update on "[compiler] Add fallthrough to branch terminal"
Branch terminals didn't have a fallthrough because they correspond to an outer terminal (optional, logical, etc) that has the "real" fallthrough. But understanding how branch terminals correspond to these outer terminals requires knowing the branch fallthrough. For example, `foo?.bar?.baz` creates terminals along the lines of: ``` bb0: optional fallthrough=bb4 bb1: optional fallthrough=bb3 bb2: ... branch ... (fallthrough=bb3) ... bb3: ... branch ... (fallthrough=bb4) ... bb4: ... ``` Without a fallthrough on `branch` terminals, it's unclear that the optional from bb0 has its branch node in bb3. With the fallthroughs, we can see look for a branch with the same fallthrough as the outer optional terminal to match them up. [ghstack-poisoned]
1 parent aeb13ee commit 8241424

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/MergeReactiveScopesThatInvalidateTogether.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import {CompilerError} from '..';
99
import {
1010
DeclarationId,
11-
DependencyPath,
1211
InstructionId,
1312
InstructionKind,
1413
Place,

0 commit comments

Comments
 (0)