Skip to content

Commit aeb13ee

Browse files
committed
Update base for Update on "[compiler] Add fallthrough to branch terminal"
Branch terminals didn't have a fallthrough because they correspond to an outer terminal (optional, logical, etc) that has the "real" fallthrough. But understanding how branch terminals correspond to these outer terminals requires knowing the branch fallthrough. For example, `foo?.bar?.baz` creates terminals along the lines of: ``` bb0: optional fallthrough=bb4 bb1: optional fallthrough=bb3 bb2: ... branch ... (fallthrough=bb3) ... bb3: ... branch ... (fallthrough=bb4) ... bb4: ... ``` Without a fallthrough on `branch` terminals, it's unclear that the optional from bb0 has its branch node in bb3. With the fallthroughs, we can see look for a branch with the same fallthrough as the outer optional terminal to match them up. [ghstack-poisoned]
2 parents 58a1e14 + 7771d3a commit aeb13ee

File tree

18 files changed

+804
-555
lines changed

18 files changed

+804
-555
lines changed

.github/workflows/runtime_commit_artifacts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
build/oss-experimental/react-refresh/cjs/react-refresh-babel.development.js
8888
- name: Insert @headers into eslint plugin and react-refresh
8989
run: |
90-
sed -i -e 's/ LICENSE file in the root directory of this source tree./ LICENSE file in the root directory of this source tree.\n * \n * @noformat\n * @nolint\n * @lightSyntaxTransform\n * @preventMunge\n * @oncall react_core/' \
90+
sed -i -e 's/ LICENSE file in the root directory of this source tree./ LICENSE file in the root directory of this source tree.\n *\n * @noformat\n * @nolint\n * @lightSyntaxTransform\n * @preventMunge\n * @oncall react_core/' \
9191
build/oss-experimental/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js \
9292
build/oss-experimental/react-refresh/cjs/react-refresh-babel.development.js
9393
- name: Move relevant files for React in www into compiled

0 commit comments

Comments
 (0)