Setup basic Hermes V1 E2E tests #54576
Closed
+303
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@j-piasecki has imported this pull request. If you are a Meta employee, you can view this in D87331639. |
facebook-github-bot
added
the
Shared with Meta
cortinico
approved these changes
Nov 18, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Nov 18, 2025
Summary: Adds a new action that will run every day after the nightly build is published. This action will set up a blank app from the template, enable Hermes V1, and run a simple E2E test on Android and iOS in both Debug and Release configurations. ## Changelog: [INTERNAL] [ADDED] - Added basic E2E tests for Hermes V1 Test Plan: I haven't tested the changes since they require larger action runners, but the changes are additive and don't impact existing infra (besides adding an optional parameter). Reviewed By: cortinico Differential Revision: D87331639 Pulled By: j-piasecki
j-piasecki
force-pushed
the
@jpiasecki/hermes-v1-tests
branch
from
8aaac77 to
59b0d1d
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87331639. |
Summary: Adds a new action that will run every day after the nightly build is published. This action will set up a blank app from the template, enable Hermes V1, and run a simple E2E test on Android and iOS in both Debug and Release configurations. ## Changelog: [INTERNAL] [ADDED] - Added basic E2E tests for Hermes V1 Test Plan: I haven't tested the changes since they require larger action runners, but the changes are additive and don't impact existing infra (besides adding an optional parameter). Reviewed By: cortinico Differential Revision: D87331639 Pulled By: j-piasecki
j-piasecki
force-pushed
the
@jpiasecki/hermes-v1-tests
branch
from
59b0d1d to
70c0825
Compare
|
@j-piasecki merged this pull request in 630f80c. |
Collaborator
|
This pull request was successfully merged by @j-piasecki in 630f80c When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds a new action that will run every day after the nightly build is published. This action will set up a blank app from the template, enable Hermes V1, and run a simple E2E test on Android and iOS in both Debug and Release configurations.
Changelog:
[INTERNAL] [ADDED] - Added basic E2E tests for Hermes V1
Test Plan:
I haven't tested the changes since they require larger action runners, but the changes are additive and don't impact existing infra (besides adding an optional parameter).