Skip to content

Conversation

@Aryaman1792
Copy link

This PR fixes a bug in the validateTypeScriptDefs function in scripts/build/build.js. The original code incorrectly passed the entire result of ts.convertCompilerOptionsFromJson to ts.createProgram, but only the options property should be used. Updated the code to extract and use parsed.options, ensuring that TypeScript definitions are validated as intended. No other logic or behavior is changed.

Summary:

Changelog:

Test Plan:

This PR fixes a bug in the validateTypeScriptDefs function in scripts/build/build.js. The original code incorrectly passed the entire result of ts.convertCompilerOptionsFromJson to ts.createProgram, but only the options property should be used.
Updated the code to extract and use parsed.options, ensuring that TypeScript definitions are validated as intended. No other logic or behavior is changed.
@meta-cla
Copy link

meta-cla bot commented Nov 10, 2025

Hi @Aryaman1792!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against b6686cc

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2025
@meta-cla
Copy link

meta-cla bot commented Nov 10, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Nov 10, 2025
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Can you add a proper changelog line and a test plan, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants