Skip to content

fix(e2e script): backport from 71 fixes to the E2E script #35477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix(e2e script): backport from 71 fixes to the E2E script #35477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dad02f6
[LOCAL] fix e2e script
kelset Nov 22, 2022
11f817e
[LOCAL] fix removal of version from Hermes tarball
kelset Nov 22, 2022
6c63797
[LOCAL] fix removal of version from Hermes tarball, part 2
kelset Nov 22, 2022
380fb2d
[LOCAL] remove the hermes engine cache in the clean script
kelset Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions scripts/release-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ function generateiOSArtifacts(
jsiFolder,
hermesCoreSourceFolder,
buildType,
releaseVersion,
targetFolder,
) {
pushd(`${hermesCoreSourceFolder}`);
Expand All @@ -109,7 +108,6 @@ function generateiOSArtifacts(
const tarballOutputPath = createHermesPrebuiltArtifactsTarball(
hermesCoreSourceFolder,
buildType,
releaseVersion,
targetFolder,
true, // this is excludeDebugSymbols, we keep it as the default
);
Expand Down
3 changes: 3 additions & 0 deletions scripts/test-e2e-local-clean.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ exec('rm -rf /tmp/maven-local');
console.info('\n** Nuking the derived data folder **\n');
exec('rm -rf ~/Library/Developer/Xcode/DerivedData');

console.info('\n** Removing the hermes-engine pod cache **\n');
exec('rm -rf ~/Library/Caches/CocoaPods/Pods/External/hermes-engine');

// RNTester Pods
console.info('\n** Removing the RNTester Pods **\n');
exec('rm -rf packages/rn-tester/Pods');
Expand Down
5 changes: 2 additions & 3 deletions scripts/test-e2e-local.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ if (argv.target === 'RNTester') {

// for this scenario, we only need to create the debug build
// (env variable PRODUCTION defines that podspec side)
const buildType = 'Debug';
const buildTypeiOSArtifacts = 'Debug';

// the android ones get set into /private/tmp/maven-local
const localMavenPath = '/private/tmp/maven-local';
Expand All @@ -207,8 +207,7 @@ if (argv.target === 'RNTester') {
const tarballOutputPath = generateiOSArtifacts(
jsiFolder,
hermesCoreSourceFolder,
buildType,
releaseVersion,
buildTypeiOSArtifacts,
localMavenPath,
);

Expand Down