Skip to content

Fix RNTester on Windows #19974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix RNTester on Windows #19974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fbe2fcd
use js instead of bash to start RNTester dev server
gengjiawen Jun 16, 2018
ddbccc9
remove redundant type
gengjiawen Jun 16, 2018
f4049cd
fix script
gengjiawen Jun 16, 2018
ac0ea69
remove obsolete file
gengjiawen Jun 27, 2018
bfd6475
revert flow-node
gengjiawen Jul 12, 2018
9c822c7
add back max workers
gengjiawen Jul 12, 2018
b69a154
revert remove type to stay this pr clean.
gengjiawen Aug 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@
"scripts/ios-install-third-party.sh",
"scripts/launchPackager.bat",
"scripts/launchPackager.command",
"scripts/packager.sh",
"scripts/react-native-xcode.sh",
"jest-preset.json",
"jest",
Expand All @@ -123,12 +122,12 @@
"third-party-podspecs"
],
"scripts": {
"start": "node ./local-cli/cli.js start",
"test": "jest",
"test-ci": "JEST_JUNIT_OUTPUT=\"reports/junit/js-test-results.xml\" jest --maxWorkers=2 --ci --testResultsProcessor=\"jest-junit\"",
"flow": "flow",
"lint": "eslint .",
"prettier": "prettier \"./**/*.js\" --write",
"start": "/usr/bin/env bash -c './scripts/packager.sh \"$@\" || true' --",
"docker-setup-android": "docker pull reactnativeci/android-base:latest",
"docker-build-android-base": "docker build -t reactnativeci/android-base -f ContainerShip/Dockerfile.android-base .",
"docker-build-android": "docker build -t reactnativeci/android -f ContainerShip/Dockerfile.android .",
Expand Down
2 changes: 1 addition & 1 deletion scripts/objc-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function waitForPackager {
if [ "$1" = "test" ]; then

# Start the packager
./scripts/packager.sh --max-workers=1 || echo "Can't start packager automatically" &
npm run start --max-workers=1 || echo "Can't start packager automatically" &
# Start the WebSocket test server
open "./IntegrationTests/launchWebSocketServer.command" || echo "Can't start web socket server automatically"

Expand Down