[RN][NewArch] Add danger block for C++ TurboModule #4402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
force-pushed
the
cipolleschi/add-danger-for-cxx-tm
branch
from
207df01 to
7fc4473
Compare
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for react-native ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
huntie
approved these changes
Dec 20, 2024
timbocole
reviewed
Dec 20, 2024
Contributor
timbocole
left a comment
timbocole
left a comment
There was a problem hiding this comment.
Thank You - this alleviates my concerns of a new dev getting very confused! 😍
cipolleschi
force-pushed
the
cipolleschi/add-danger-for-cxx-tm
branch
from
7fc4473 to
41ae98b
Compare
Contributor
|
@cipolleschi As of 0.76.6 this issue has now been resolved - not sure if you want to completely remove the danger block now? |
cipolleschi
added a commit
that referenced
this pull request
Jan 15, 2025
This reverts commit a94002d.
Contributor
Author
|
@timbocole thanks for getting back at this. This is a quick pr to revert this commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered that in App pure Cxx Turbomodules stopped working from version 0.76 of React Native.
We have the issue tracking it and a potential fix for it.
Given the Christmas break, we are not going to be able to ship a new release of React Native with the fix. Therefore we want to document this problem in the website.