Fix FacebookResponse.is_success to properly handle API returns in csv format #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK breaks when trying to run an API call that returns a string body (in csv format, for example).
This is what happens:
json_body = self.json()if isinstance(json_body, collections_abc.Mapping) and 'error' in json_body:json_bodyis a dict when looking for a dictionary key in itelif bool(json_body):json_bodyis not empty (str or dict) or False.if 'success' in json_body:json_bodyis a dictjson_bodyis a string the code is looking for a substring instead of a dictionary keyreturn json_body['success']return 'Service Unavailable' not in json_body