[Expo] Prevent the use of react-native internals with react-native-web #6813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Timer,
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
EvanBacon
changed the title
heyimalex
reviewed
Apr 16, 2019
|
😍 any way I can do to push this along?! |
|
How the impact on depends and legacy displays? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently difficult to create more advanced aliases on top of
react-native-web. We do the same in theexpo-clihere. It'd be nice to emulate this without directly switching off ofreact-scripts. Here is an example that would work given this PR is merged: Code sandbox. You could then use Unimodules in code sandbox, or withreact-scriptswith minimal friction.It's also bad practice to use
react-nativeinternals. The majority (if not all) of them don't work because the internal structure ofreact-native-webis optimized forbabel-plugin-react-native-web.CC: @necolas