Skip to content

Fix wrong path expansion in end-to-end test #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2017
Merged

Fix wrong path expansion in end-to-end test #2388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbdcb07
Update e2e-kitchensink.sh
gaearon May 27, 2017
47f29dc
Try again (differently)
gaearon May 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tasks/e2e-kitchensink.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,13 @@ REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true \
NODE_PATH=src \
NODE_ENV=test \
npm test -- --no-cache --testPathPattern="/src/"
npm test -- --no-cache --testPathPattern=src

# Catch when no tests are detected
testsList=$(REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true \
NODE_PATH=src \
npm test -- --no-cache --testPathPattern="/src/" --listTests)
npm test -- --no-cache --testPathPattern=src --listTests)

if [[ ${testsList} =~ "[]" ]]; then
exit 1
Expand Down Expand Up @@ -230,7 +230,7 @@ REACT_APP_SHELL_ENV_MESSAGE=fromtheshell \
CI=true \
NODE_PATH=src \
NODE_ENV=test \
npm test -- --no-cache --testPathPattern='/src/'
npm test -- --no-cache --testPathPattern=src

# Test "development" environment
tmp_server_log=`mktemp`
Expand Down