feat: provide more details to KubernetesClientException #3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
If the exception occurred from an HTTP request, use that information to populate information about the target resource. Fixes #3491
metacosm
force-pushed
the
improve-exceptions-2
branch
from
011f9cc to
97be902
Compare
manusa
reviewed
Sep 23, 2021
...client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/WatcherWebSocketListener.java
Outdated
Show resolved
Hide resolved
metacosm
added a commit
to operator-framework/java-operator-sdk
that referenced
this pull request
Sep 23, 2021
Note that this relies on fabric8io/kubernetes-client#3492 so won't build until this PR is merged and available in a release. Fixes #552
|
SonarCloud Quality Gate failed. |
rohanKanojia
approved these changes
Sep 23, 2021
manusa
reviewed
Sep 23, 2021
Comment on lines
+728
to
+740
| static RequestMetadata from(Request request) { | ||
| final List<String> segments = request.url().pathSegments(); | ||
| switch (segments.size()) { | ||
| case 4: | ||
| // cluster URL | ||
| return new RequestMetadata(segments.get(1), segments.get(2), segments.get(3), null); | ||
| case 6: | ||
| // namespaced URL | ||
| return new RequestMetadata(segments.get(1), segments.get(2), segments.get(5), segments.get(4)); | ||
| default: | ||
| return EMPTY; | ||
| } | ||
| } |
There was a problem hiding this comment.
Are you sure this switch handles all the use-cases?
e.g. subresources, cluster-scoped resources targeting a namesoace, non-standard resources (metrics server, pod exec...), etc.?
There was a problem hiding this comment.
I'll merge this PR because this is apparently harmless as it's provided as a new feature.
manusa
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the exception occurred from an HTTP request, use that information
to populate information about the target resource.
Fixes #3491
Type of change
test, version modification, documentation, etc.)
Checklist