1.7.6 from 1.3.0 #61
1.7.6 from 1.3.0 #61
Conversation
ebrigand
commented
Jan 12, 2017
ebrigand
commented
- plugin build process is coming from the tag elasticsearch-cloud-kubernetes-2.4.0_01 (to be able to use the Dockerfile and to have the last building process coming with the last maven pom file)
- Dockefile install ES 1.7.6
- Java class are coming from the tag elasticsearch-cloud-kubernetes-1.3.0
jimmidyson
left a comment
jimmidyson
left a comment
There was a problem hiding this comment.
Thanks for sending this in. Can you review the readme & make sure it is consistent with the 1.7 configuration?
LICENSE.txt
Outdated
| @@ -1,3 +1,18 @@ | |||
| ==== | |||
There was a problem hiding this comment.
This file should not have changed.
NOTICE.txt
Outdated
| @@ -1,0 +1,16 @@ | |||
| ==== | |||
There was a problem hiding this comment.
This file isn't actually required.
README.md
Outdated
| cloud: | ||
| k8s: | ||
| servicedns: ${SERVICE_DNS} | ||
| kubernetes: |
There was a problem hiding this comment.
These options look like from later version? Can you update please to reflect the 1.3.x config?
README.md
Outdated
| namespace: ${NAMESPACE} | ||
| discovery: | ||
| type: io.fabric8.elasticsearch.discovery.k8s.K8sDiscoveryModule | ||
| type: kubernetes |
…csearch-cloud-kubernetes-2.4.0_01
…ince what we had was a copy past of the official dockerfile and no need of an entrypoint, it will use the official one
ebrigand
left a comment
ebrigand
left a comment
There was a problem hiding this comment.
Review done and i fixed some small glitch like I was using our docker id so i put back fabric8.
And I decided to change the Dockerfile to put a FROM using the official image instead of using a full copy past of their Dockerfile, same for the entry-point.sh we don't need it since it s the same as the official one
2 participants
