Remove special case for strings in pydevd_sys_monitoring #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Oct 29, 2024
| return check_version(mod.__version__, "1.0.3") | ||
| else: | ||
| return True | ||
|
|
There was a problem hiding this comment.
This was a fix for qt loading that somebody submitted to debugpy
rchiodo
commented
Oct 29, 2024
| return _cache_file_type[cache_key] | ||
| except: | ||
| if abs_real_path_and_basename[0] == "<string>": | ||
| # TODO: This isn't ideal. We should make it so that "<string>" is |
There was a problem hiding this comment.
We don't need this anymore after eliminating the internal lambda in _pydevd_sys_monitoring.py
rchiodo
commented
Oct 29, 2024
| writer.finished_ok = True | ||
|
|
||
|
|
||
| def test_stop_on_entry_verify_strings(case_setup_dap): |
There was a problem hiding this comment.
This test doesn't work anymore since there's no longer a special case for pydevd strings.
rchiodo
commented
Oct 29, 2024
| filename = frame.f_code.co_filename | ||
| name = splitext(basename(filename))[0] | ||
| return "%s::%s %s" % (name, frame.f_code.co_name, frame.f_lineno) | ||
| line = hasattr(frame, "f_lineno") and frame.f_lineno or 1 |
There was a problem hiding this comment.
Just some minor fixes I noticed when debugging.
rchiodo
changed the title
|
Just applied. Thank you for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled the latest from PyDev.Debugger into debugpy and figured out what was causing the weird string problem. It was the
namedtuplefor the_CodeLineInfo. It was generating a lambda that caused problems with theget_file_typeAPI.Changing the
_CodeLineInfoto an actual class gets rid of the lambda.I'm also pushing over some changes that other people made in debugpy.