Skip to content

Conversation

@agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jul 29, 2022

NOTE: this is built on top of #404 as it uses the context changes made there. #404 is itself built on top of #397. As such, I've marked this PR as "Draft" until those PRs are merged.
Rebased on top and marked as ready for review.

Summary

Adds unit tests for all scenarios of print-diagnostics.ts

Details

  • test all the different categories and formattings
  • full unit test coverage now! (except for index/tscache, which integration tests cover)

@agilgur5 agilgur5 added kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests labels Jul 29, 2022
@agilgur5 agilgur5 force-pushed the test-add-print-diagnostics branch from ae58a08 to db8b4c0 Compare August 24, 2022 15:46
- test all the different categories and formattings
- full unit test coverage now! (except for `index`/`tscache`, which integration tests cover)
@agilgur5 agilgur5 force-pushed the test-add-print-diagnostics branch from db8b4c0 to a19829b Compare August 25, 2022 05:13
@agilgur5 agilgur5 marked this pull request as ready for review August 25, 2022 05:17
@agilgur5 agilgur5 requested a review from ezolenko August 25, 2022 05:17
@ezolenko ezolenko merged commit 27356be into ezolenko:master Aug 25, 2022
@agilgur5 agilgur5 deleted the test-add-print-diagnostics branch July 2, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: tests Tests could be improved. Or changes that only affect tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants