Skip to content

refactor: move snapshot check into typecheckFile #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022
Merged

refactor: move snapshot check into typecheckFile #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,19 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
}));
}

const typecheckFile = (id: string, snapshot: tsTypes.IScriptSnapshot, tcContext: IContext) =>
const typecheckFile = (id: string, snapshot: tsTypes.IScriptSnapshot | undefined, tcContext: IContext) =>
{
id = normalize(id);
checkedFiles.add(id); // must come before print, as that could bail
if (!snapshot)
return;

const diagnostics = getDiagnostics(id, snapshot);
printDiagnostics(tcContext, diagnostics, parsedConfig.options.pretty !== false);
id = normalize(id);
checkedFiles.add(id); // must come before print, as that could bail

if (diagnostics.length > 0)
noErrors = false;
const diagnostics = getDiagnostics(id, snapshot);
printDiagnostics(tcContext, diagnostics, parsedConfig.options.pretty !== false);

if (diagnostics.length > 0)
noErrors = false;
}

/** to be called at the end of Rollup's build phase, before output generation */
Expand Down Expand Up @@ -289,8 +292,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
return;

const snapshot = servicesHost.getScriptSnapshot(id);
if (snapshot)
typecheckFile(id, snapshot, context);
typecheckFile(id, snapshot, context);
});
}

Expand All @@ -304,10 +306,8 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
return;

context.debug(() => `type-checking missed '${key}'`);

const snapshot = servicesHost.getScriptSnapshot(key);
if (snapshot)
typecheckFile(key, snapshot, contextWrapper);
typecheckFile(key, snapshot, contextWrapper);
});

buildDone();
Expand Down