refactor: split out a common typecheckFile func
#344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this is used in 3 places and going to be more for the code I'm adding
to fix type-only imports
- so DRY it up and standardize the functionality too
- some places had `noErrors = false` in one place while others had
it in another
- same for `printDiagnostics`
- but the ordering actually doesn't matter, so just keep it
consistent and the same
- and then can split a common function that does both out
- technically, now getDiagnostics is _only_ used in typecheckFile, so
I could link to the two together, but I'm refactoring that one up
a little
- but this a good, small example of how refactoring one part of a
codebase can make it easier to identify more similar pieces and then
refactor even more
agilgur5
added
the
kind: internal
|
@ezolenko this one's ready to merge -- not sure if you skipped it intentionally or not |
|
@agilgur5 just the comment on line 204 |
|
@ezolenko oh, I don't see a comment -- I think maybe you didn't hit "Submit Review"? Code comments are saved as draft by default |
ezolenko
reviewed
Jun 17, 2022
|
Ah, no wonder... |
5 tasks
agilgur5
added
the
topic: TS Compiler API Docs
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Split out a common
typecheckFilefunction used in 3+ places to DRY up more codeDetails
this is used in 3 places and going to be more for the code I'm adding to fix type-only imports in fix: type-check
included files missed bytransform(type-only files) #345 (and probably more type-only PRs in the future)noErrors = falsein one place while others had it in anotherprintDiagnosticstechnically, now
getDiagnostics(from refactor: prefer native methods to lodash where possible #328) is now only used intypecheckFile, so I could combine the two together, but I'm refactoring that one up a little