Add RNA Transcription exercise #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houli
force-pushed
the
rna-transcription
branch
from
5280c50 to
e7afdb1
Compare
|
Hmm looks like Travis is timing out. @lpil @icyrockcom Any ideas? I'll restart it for now. |
paf31
reviewed
Oct 19, 2017
| "output" | ||
| ], | ||
| "dependencies": { | ||
| "purescript-console": "^3.0.0", |
There was a problem hiding this comment.
I don't think you need all of these.
There was a problem hiding this comment.
Right, not sure what the deal is with the individual bower json files, the README isn't so clear. All of the exercises seem to have the same set of dependencies
There was a problem hiding this comment.
I believe all the exercises share the same deps now so that we can cache easier on CI
paf31
reviewed
Oct 19, 2017
| import Data.Traversable (traverse) | ||
|
|
||
| toRNA :: String -> Maybe String | ||
| toRNA dna = fromCharArray <$> traverse complement (toCharArray dna) |
paf31
approved these changes
Oct 19, 2017
|
If you could please resolve conflicts here, I'll get this merged. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly followed the current exercises, in particular this PR #44. I see that some of the
config.jsonkeys have changed since that pull request so this will probably need some changes there.