-
-
Notifications
You must be signed in to change notification settings - Fork 557
[roman-numerals] Tidy up grammer and formatting. #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| The Romans wrote numbers using letters - I, V, X, L, C, D, M. | ||
| (notice these letters have lots of straight lines and are hence easy to hack into stone tablets). | ||
| (Notice these letters have lots of straight lines and are hence easy to hack into stone tablets). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 13 appears as an aside related to line 12 so I'd remove the period from line 12 and keep notice lowercase.
That'd look like this then.
"The Romans wrote numbers using letters - I, V, X, L, C, D, M (notice these letters have lots of straight lines and are hence easy to hack into stone tablets)."
That suggested fix applies to any other asides bracketed by parentheses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would mean removing the . from the end of line 12 and moving it to the end of line 13? And joining the two lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's one sentence, should it be:
The Romans wrote numbers using letters - I, V, X, L, C, D, M; notice these letters have lots of straight lines and are hence easy to hack into stone tablets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works too. They're both complete sentences so there's no reason they can't be joined with a semi-colon. As an aside, it's longer than the rest of the sentence so it looks a little weird in my original suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was your original sentence to keep them as separate sentences? I thought removing the period meant making them one sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made them one sentence with the intention to keep the original second sentence the aside I thought it was. Your version flows better though with the semi-colon and no parentheses.
|
|
||
| The maximum number supported by this notation is 3,999. | ||
| (The Romans themselves didn't tend to go any higher) | ||
| (The Romans themselves didn't tend to go any higher.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove this line. Romans did and could go higher using alternatives forms of notation. https://mathworld.wolfram.com/RomanNumerals.html
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it! @iHiD next up: splitting this into an instructions and introduction document?
No description provided.