bin/fetch-configlet: sync with upstream #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetch-configlet script in this repo was outdated. Update it to the upstream version [1], which has many improvements. Closes: exercism#2258 [1] https://github.com/exercism/configlet/blob/85745ac34f7c/scripts/fetch-configlet
IsaacG
approved these changes
Apr 10, 2023
Contributor
|
Why do we need configlet in this repo? |
Member
Author
Good question. I think the answer is that we don't anymore. I'll suggest removing the fetch configlet scripts from this repo as a follow-up. We might need to edit some of the docs in this repo that mention configlet. |
Member
|
I propose we sync from upstream first. This is a pretty simple and straight forward PR. That unblocks the bash cleanup PR and we can follow up on removing the script as a follow up issue. |
glennj
approved these changes
Apr 11, 2023
vaeng
approved these changes
Apr 11, 2023
Contributor
vaeng
left a comment
vaeng
left a comment
There was a problem hiding this comment.
"The two files are identical"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetch-configlet script in this repo was outdated. Update it to the upstream version, which has many improvements.
Closes: #2258