Skip to content

Conversation

habere-et-dispertire
Copy link
Contributor

@habere-et-dispertire
Copy link
Contributor Author

I based this off the three files I found in the Beer Song exercise. I used fresh UUIDs (from configlet).

Is there anything else that needs doing? Thanks. :)

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I'll let someone who is familiar with the current state of this repo do the merging, though, in case I've missed something since the last time I touched it.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe this is all right, except for the markdown to be incorrectly formatted. See https://exercism.org/docs/building/markdown/markdown#h-layout.

I know the old exercise is not yet in this format, but new contributions should.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to deprecate the old beer-song exercise? If so, we should add a .deprecated file to it, similar to https://github.com/exercism/problem-specifications/blob/main/exercises/binary/.deprecated

@habere-et-dispertire habere-et-dispertire marked this pull request as ready for review September 28, 2022 09:42
@ErikSchierboom
Copy link
Member

Maybe a sanity check from @exercism/reviewers?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong deprecation note, or at least, I think, in the wrong location.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the changes since my last review. I think this is good to go, so let's get this merged. Thanks @habere-et-dispertire !

@SleeplessByte SleeplessByte merged commit b53a879 into exercism:main Sep 29, 2022
@SleeplessByte
Copy link
Member

@iHiD perhaps want a similar icon, should be easy for Taiy.

@habere-et-dispertire
Copy link
Contributor Author

I thank each and every one of you for your help. Much appreciated! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants