-
-
Notifications
You must be signed in to change notification settings - Fork 555
Ten Green Bottles #2097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ten Green Bottles #2097
Conversation
I based this off the three files I found in the Beer Song exercise. I used fresh UUIDs (from configlet). Is there anything else that needs doing? Thanks. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I'll let someone who is familiar with the current state of this repo do the merging, though, in case I've missed something since the last time I touched it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also believe this is all right, except for the markdown to be incorrectly formatted. See https://exercism.org/docs/building/markdown/markdown#h-layout.
I know the old exercise is not yet in this format, but new contributions should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to deprecate the old beer-song
exercise? If so, we should add a .deprecated
file to it, similar to https://github.com/exercism/problem-specifications/blob/main/exercises/binary/.deprecated
Maybe a sanity check from @exercism/reviewers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong deprecation note, or at least, I think, in the wrong location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the changes since my last review. I think this is good to go, so let's get this merged. Thanks @habere-et-dispertire !
@iHiD perhaps want a similar icon, should be easy for Taiy. |
I thank each and every one of you for your help. Much appreciated! :) |
A renaming of the Beer Song.
See: [Suggestion] Rename the Beer Song to Ten Green Bottles #2066