space-age: restrict seconds to fit within 32-bit int range #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmccandless
approved these changes
Jan 14, 2019
Member
Author
|
It's been 72 hours and there have been no objections, so I'll merge this. |
Member
|
Sort of a posthumous 👍 (since it is already merged). Thanks for making the change. |
sshine
pushed a commit
to exercism/haskell
that referenced
this pull request
Oct 10, 2019
restrict seconds to fit within 32-bit int range exercism/problem-specifications#1441
petertseng
pushed a commit
to exercism/rust
that referenced
this pull request
Nov 9, 2019
Version 1.2.0 modifies the input values so that the number of seconds fits into an `i32`. The expected values are updated to reflect the change. Relevant PRs: - 1.1.0 -> 1.2.0: exercism/problem-specifications#1441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1437