patch: handle submitted complilation error #97
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently a compilation error was classified as a test failure, however this causes the website to show all of the dependent test cases which appear to be passing (despite actually not being run), because the j-unit output doesn't have a success child element to indicate success, only the absense of a skipped/failure element indicates success.
neenjaw
force-pushed
the
patch-error-case
branch
from
4571847 to
9e3e245
Compare
Contributor
Author
|
Following the CI run here: Will need to more closely look at how to consider errors in test cases as distinct from errors in the test file. |
Contributor
|
Maybe you can run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently a compilation error was classified as a test failure, however
this causes the website to show all of the dependent test cases which
appear to be passing (despite actually not being run), because the
j-unit output doesn't have a success child element to indicate success,
only the absense of a skipped/failure element indicates success.