Skip to content

Fix #488 use non-ascii punctuation, not letters #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fix #488 use non-ascii punctuation, not letters #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3be34d3
Fix #488 use non-ascii punctuation, not letters
cmcaine Mar 26, 2023
e0f7db9
Avoid diacritics ambiguities in unicode testcase
cmcaine Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions exercises/practice/pangram/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ end
@test ispangram("the 1 quick brown fox jumps Over the 2 lazy dogs")
end

@testset "letters that aren't part of ASCII" begin
@test !ispangram("the 1 qüick bröwn föx jümps över the 2 läzy dögs")
@testset "An Arabic pangram is not an English pangram" begin
@test !ispangram("The scholar and poet Al Farāhīdi wrote this Arabic pangram: صِف خَلقَ خَودِ كَمِثلِ الشَمسِ إِذ بَزَغَت — يَحظى الضَجيعُ بِها نَجلاءَ مِعطارِ")
end