Skip to content

upgrade acronym to 1.7.0 (add extra test case) #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2019
Merged

upgrade acronym to 1.7.0 (add extra test case) #861

merged 2 commits into from
Oct 10, 2019

Conversation

@sharno
Copy link
Contributor

@sharno sharno commented Oct 10, 2019 •
edited by sshine
Loading

add underscore test case

fix the text example to pass the newly added test case

exercism/problem-specifications#1436

sshine
sshine approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@sshine sshine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I'm appending the following to the commit message:

add underscore test case

fix the text example to pass the newly added test case

exercism/problem-specifications#1436

@sshine sshine merged commit 9252572 into exercism:master Oct 10, 2019
@sshine sshine mentioned this pull request Oct 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sshine sshine sshine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

sync/tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sharno @sshine @petertseng