Update button for more minimal style inspired by jupyterlab #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
changed the title
|
Looks good, and the ">" for the closed / click to open state (and the "v" for the opened state) feels right, and seems customary: https://ux.stackexchange.com/a/5736/155097 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick attempt at implementing #46 to see how it looks and for feedback.
Note that it simplifies things a bit further, and doesn't have the blue line extend down below...I think that this makes it a little bit less intrusive and also doesn't shift the content horizontally. It uses the same blue as the JupyterLab UI default theme.
It also fixes a bug on the book theme where there'd be a "dangling" part of the admonition when it was hidden, and adds a bit of "hover interactivity" to make things more obvious when they're interactable.
Here's a demo:
closes #46