Move from attrs
to dataclasses
#200
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Token.as_dict
-- Moved to using a simpledataclasses.asdict
call. This means that many keyword arguments are removed from the method. Output is also slightly different (see.yml
test regression files in this PR).EDIT: Answering my own question: Without keyword arguments,Token.copy
-- Moved fromattr.evolve
to a simplecopy.copy
call. The stdlibcopy.copy
call does quite literally what the docstring ofToken.copy
says which is "return a shallow copy of the instance". Doesattr.evolve
do something extra? Is there a chance someone relies on this extra behavior?attr.evolve
seems doesn't seem to do anything thatcopy.copy
doesn't. I don't think this is a breaking change.