Skip to content

Explicity reexport MarkdownIt #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

paw-lu
Copy link

@paw-lu paw-lu commented Oct 26, 2021

Explicitly export MarkdownIt.

Adds MarkdownIt to __all__.

This:

  1. Allows markdown_it to pass strict mypy type checking, specifically --no-implicit-reexport
  2. Removes the need for ignoring F401, as flake8 detects the use in __all__

@welcome
Copy link

welcome bot commented Oct 26, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@paw-lu
Copy link
Author

paw-lu commented Oct 26, 2021

I actually see this was attempted in #120—though it was a more drastic proposal. Feel free to close if this is just adding noise.

@chrisjsewell
Copy link
Member

Now merged #120, but thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants