Skip to content

Add Windows environment info collector to the WPF platform #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

mgnslndh
Copy link
Contributor

Fixes #290 by add source link to ExceptionslessWindowsEnvironmentInfoCollector in the WPF platform project and registering that services to the dependency resolver.

          You should only need to use the Wpf client, code is shared between the clients. I'm trying to think if there is any reason we shouldn't be capturing that environment info in wpf. I can't think of any reason not to.. Would you mind submitting a pr to add a source link to that file in the wpf project and then adding a line to `client.Configuration.Resolver.Register<IEnvironmentInfoCollector, ExceptionlessWindowsEnvironmentInfoCollector>();` in register.

Originally posted by @niemyjski in #290 (comment)

@mgnslndh
Copy link
Contributor Author

Not sure why the tests fail because they green on my machine :)

@niemyjski
Copy link
Member

@mgnslndh can you sign the cla, looks like a flakey test we need to look into.

@mgnslndh
Copy link
Contributor Author

Cloudflare is reporting the clahub as down. Not sure if it is affected by the service outage at Microsoft.
https://www.clahub.com/agreements/exceptionless/Exceptionless

I will sign as soon as I can when the site is up and running.

@mgnslndh
Copy link
Contributor Author

@niemyjski I've signed the CLA. The link was wrong but I've submitted another PR fixing that.

@niemyjski niemyjski merged commit 2f9abab into exceptionless:main Jan 27, 2023
@niemyjski
Copy link
Member

Thanks for the PR!

@niemyjski niemyjski self-requested a review January 27, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Exceptionless.Windows vs Exceptionless.Wpf
2 participants