Support for disabling Sanitization #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran into this issue, glad to see someone already submitted a fix for it, thanks |
|
Is there some reason this hasn't been merged? I'd really like to use this. |
|
Bump here -- is there a good reason not to merge this? It is behind an option so it should not affect anyone who doesn't want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While sanitization is an important feature of a markdown parser, it is sometimes useful to disable it. For example, on Discourse we have our own sanitizer that is executed further down the pipeline after the markdown has been rendered, so we needn't execute the sanitization twice. Also, ours is a little more flexible and allows particular tags to be whitelisted.
This patch supports an option,
sanitize: false, when rendering, to not perform sanitization. This option is not set by default so the existing behaviour stays the same unless expressly disabled.Note this patch is based on the src attribute PR because it includes two rendering tests which belong to a newly introduced file in that PR.