Skip to content

Conversation

@alexkutsan
Copy link
Contributor

On NIX OS there is no /bin/bash.
It located in

▶ where bash
/run/current-system/sw/bin/bash

But /usr/bin/env should be on most of Linux distros

On NIX OS there is no /bin/bash.
It located in 
```
▶ where bash
/run/current-system/sw/bin/bash
```

But /usr/bin/env should be on most of Linux distros
@evertramos
Copy link
Owner

Yeah.. I being using this in all other scripts and forgot to update this one. Thanks!

@evertramos evertramos merged commit 1bc57b1 into evertramos:master Feb 11, 2020
@alexkutsan alexkutsan deleted the patch-2 branch February 25, 2020 10:35
@teslasoft-de
Copy link

teslasoft-de commented Apr 7, 2020

Guys, can you please explain why you are:

  • accepting a change for an insecure shebang statement?
    (sorry but different bash versions on one host in the age of docker is nonsense)
    Searching for bash in env is evil. If I would wear a black hat then all your base are belong to us...
  • changing the shebang of only one sh file, why not all other files too? (Please don't do it)

Please don't take me wrong, Docker-Compose-Letsencrypt is one of the coolest projects ever.
I LOVE IT!
But it gets frustrating if things stop working after an update...

@evertramos
Copy link
Owner

Hello @teslasoft-de!

You have your point of view which I agree in part as I have used FreeBSD and even Solaris in the past which we would need this portability.

I am pushing these docker scripts to a whole new level and will make it public in a few month now. I will keep this updated with this version. I have being working too much due to covid... as most of us.

Let's discuss the best option to accomplish those who need this portability. No need it for myself these days, once all my sever's images are well customized using regular bash, so I would be glad to use only /bin/bash shebang.

Thanks for you message and your concern.

What do you guy think?

@j7an, @fracz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants