Improve schema detection and customizing #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonSchemaAwareRecordLogiccan now be enabled to allow nested property schema. This means that if a property type is ofJsonSchemaAwareRecord, the property schema is derived fromJsonSchemaAwareRecord::__schema()instead of using a type reference.Collection types can implement
JsonSchemaAwareCollectionand useJsonSchemaAwareCollectionLogicto be converted to array schema with an item schema.If a property type class does not implement one of the two JsonAware* classes then the record logic checks existence of named constructors that give a hint to a scalar PHP type represented by the type class.
I've added a bunch of tests that can be used as a reference as well.