Don't print an error and exit on uncaughtException if there are other uncaughtException listeners present. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncaughtException listeners present.
|
👍 |
1 similar comment
|
+1 |
|
@crispy1989 Could you rebase this PR on top of the latest master? |
|
Also, this tests passes without the patch because of how compareLines works :( |
Merged
|
Fixed by #77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node's default behavior is to only print an exception and exit if there is no other uncaughtException handler registered. This emulates that default behavior by bypassing the uncaughtException handler if other handlers are registered.