Skip to content

fix: add even stricter checks in fInverse() fuzz test #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

fix: add even stricter checks in fInverse() fuzz test #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/CurveLib.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contract CurveLibTest is EulerSwapTestBase {
// Params
px = 1e18;
py = bound(py, 1, 1e36);
x0 = bound(x0, 1e2, 1e28);
x0 = bound(x0, 1, 1e28);
y0 = bound(y0, 0, 1e28);
cx = bound(cx, 1, 1e18);
cy = bound(cy, 1, 1e18);
Expand All @@ -63,9 +63,7 @@ contract CurveLibTest is EulerSwapTestBase {
protocolFeeRecipient: address(0)
});

// Note without -2 in the max bound, f() sometimes fails when x gets too close to centre.
// Note small x values lead to large y-values, which causes problems for both f() and fInverse(), so we cap it here
x = bound(x, 1e2 - 3, x0 - 3);
x = bound(x, 1, x0);

uint256 y = CurveLib.f(x, px, py, x0, y0, cx);
console.log("y ", y);
Expand All @@ -83,7 +81,9 @@ contract CurveLibTest is EulerSwapTestBase {

if (x < type(uint112).max && y < type(uint112).max) {
assert(CurveLib.verify(p, xCalc, y));
assert(int256(xCalc) - int256(xBin) <= 3 || int256(yCalc) - int256(yBin) <= 3); // suspect this is 2 wei error in fInverse() + 1 wei error in f()
console.log("Invariant passed");
assert(xCalc - xBin <= 3 || y - yCalc <= 3); // suspect this is 2 wei error in fInverse() + 1 wei error in f()
console.log("Margin error passed");
}
}

Expand Down