Skip to content

avoid use of assembly in getParams (suggested by @MiloTruck) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

avoid use of assembly in getParams (suggested by @MiloTruck) #69

merged 1 commit into from
Apr 29, 2025

Conversation

@hoytech
Copy link
Contributor

@hoytech hoytech commented Apr 29, 2025

No description provided.

@hoytech hoytech requested a review from MiloTruck April 29, 2025 03:55
@hoytech hoytech force-pushed the simplify-getParams branch from d3e461d to 533934e Compare April 29, 2025 03:56
MiloTruck
MiloTruck approved these changes Apr 29, 2025
View reviewed changes
Copy link

@MiloTruck MiloTruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, getParams() now ensures the calldata length is at least 384 and extracts the last 384 bytes via slicing.

@hoytech hoytech merged commit 6e8a8c8 into master Apr 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MiloTruck MiloTruck MiloTruck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoytech @MiloTruck