Skip to content

Conversation

@mdalp
Copy link
Contributor

@mdalp mdalp commented Sep 3, 2025

What was wrong?

Since python3.12 datetime.datetime.utcnow is deprecated, this raises a warning.

How was it fixed?

Using the .now() method passing the UTC timezone explicitly.
I used datetime.timezone.utc instead of datetime.UTC due to compatibility issues, i.e. py38 doesn't have the datetime.UTC shortcut to datetime.timezone.utc.

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Cute animal picture

@mdalp mdalp force-pushed the resolve-datetime-utcnow-deprecation branch from 8bb2568 to 60d5d64 Compare September 3, 2025 12:57
@marcello-pv01
Copy link

marcello-pv01 commented Sep 4, 2025

CI failure is - likely - caused by flakiness depending on the performance of the CI node.
A restart should resolve it, but I don't think I can trigger a restart.

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@kclowes kclowes merged commit df0ce3b into ethereum:main Sep 12, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants