Skip to content

Conversation

@fselmo
Copy link
Collaborator

@fselmo fselmo commented May 7, 2025

What was wrong?

Closes #3691

How was it fixed?

  • re-compile test contracts with new Solidity v0.8.30
  • re-generate test fixture using newest geth v1.15.11
  • fix some tests related to newer geth behavior

Todo:

  • Clean up commit history
  • Add or update documentation related to these changes
  • Add entry to the release notes

Cute Animal Picture

Screenshot 2025-05-07 at 12 05 18

@fselmo fselmo self-assigned this May 7, 2025
@fselmo fselmo requested review from kclowes, pacrob and reedsa May 7, 2025 18:11
Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the old fixture didn't get removed? but other than that lgtm! 🚢

@fselmo fselmo force-pushed the bump-geth-and-solidity branch from fd70549 to 8b38566 Compare May 7, 2025 18:55
@fselmo fselmo merged commit 03d186c into ethereum:main May 7, 2025
42 of 85 checks passed
@fselmo fselmo deleted the bump-geth-and-solidity branch May 7, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recompile test contracts with new Solidity version: v0.8.30

3 participants