Upgrade to py-evm 0.3.0a8 #1255
Conversation
cburgdorf
force-pushed
the
christoph/chore/upgrade-evm
branch
13 times, most recently
from
8a9383b to
3dce761
Compare
| 'randomStatetest94_Homestead', | ||
| 'randomStatetest94_Byzantium', | ||
| 'randomStatetest94_Constantinople', | ||
| 'randomStatetest94_ConstantinopleFix', |
There was a problem hiding this comment.
These ☝️ four tests kept crashing CI (they work locally) and they were also put into the slow tests on the Py-EVM side.
There was a problem hiding this comment.
IIRC, veox said something about the tests having high RAM usage.
There was a problem hiding this comment.
@cburgdorf That's correct. Those tests need more than 4gb of RAM(discovered here). And they were marked as slow in this commit.
| await validate_accounts(rpc, chain_fixture['postState']) | ||
| # Fixtures do not include the `postState` field when its size would be past a certain limit. | ||
| # https://github.com/ethereum/tests/issues/637#issuecomment-534072897 | ||
| if chain_fixture.get('postState', None): |
There was a problem hiding this comment.
@carver I was a bit worried if we are losing any safety here but it seems that we are doing the same on the Py-EVM side and I think that we are still safe here because even if we do not validate the postState for these special cases we do validate the lastblockhash.
There was a problem hiding this comment.
❤️ for the link to the convo. After reading it, I agree
| ALL_VMS_BY_FORK = { | ||
| vm_class.fork: vm_class | ||
| for vm_class in ALL_VMS | ||
| } |
There was a problem hiding this comment.
This was just dead code
cburgdorf
force-pushed
the
christoph/chore/upgrade-evm
branch
from
3dce761 to
977f7f8
Compare
| 'ShanghaiLove_Homestead', | ||
| 'ShanghaiLove_Frontier', | ||
| 'DelegateCallSpam', | ||
| 'walletReorganizeOwners', |
There was a problem hiding this comment.
Don't get confused, I just resorted this list alphabetically (in a separate commit), so there are really only four new tests in that list.
cburgdorf
force-pushed
the
christoph/chore/upgrade-evm
branch
from
977f7f8 to
e382cfc
Compare
| await validate_accounts(rpc, chain_fixture['postState']) | ||
| # Fixtures do not include the `postState` field when its size would be past a certain limit. | ||
| # https://github.com/ethereum/tests/issues/637#issuecomment-534072897 | ||
| if chain_fixture.get('postState', None): |
There was a problem hiding this comment.
❤️ for the link to the convo. After reading it, I agree
cburgdorf
force-pushed
the
christoph/chore/upgrade-evm
branch
from
5b8bfde to
bba5162
Compare
|
Closed #1186 |
3 participants
What was wrong?
Trinity needs to be upgraded to the latest py-evm version to:
How was it fixed?
setup.pyvoodoomainnet.jsonvodooIstanbulVMwhere appropriateCute Animal Picture