Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Add more tests for rewards #1315

@cburgdorf

Description

@cburgdorf

What is wrong?

We recently added unit tests (additional to the existing state tests) that cover the rewards that are paid to the miners.

We should expand the following cases (citing from)

  • calculating uncle/nephew reward when the uncle is on a different VM (like: uncle in frontier at 0, nephew in constantinople at 1)
  • uncles that are 2 -> 8 layers back
  • validating that uncles > 8 back are invalid

(I'm saying the last two without having reviewed the uncles section of the YP recently, so probably have some detail wrong)

How can it be fixed

Add test here

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions