Skip to content

clients/go-ethereum: remove deprecated PoW #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2023
Merged

clients/go-ethereum: remove deprecated PoW #773

merged 4 commits into from
May 4, 2023

Conversation

@s1na
Copy link
Contributor

@s1na s1na commented May 3, 2023

Geth PoW mining and real verification, and as a result many of the utilities used in tests such as makecache makedag etc.

The --fakepow flag is also removed. Now a merge-ready network is required and in that case a PoW fake verifier will be available. To trigger this we set "terminalTotalDifficultyPassed": true.

ethereum/go-ethereum#27178

@s1na s1na marked this pull request as draft May 3, 2023 15:58
@fjl fjl changed the title geth: remove deprecated PoW clients/go-ethereum remove deprecated PoW May 3, 2023
@fjl fjl changed the title clients/go-ethereum remove deprecated PoW clients/go-ethereum: remove deprecated PoW May 3, 2023
holiman
holiman reviewed May 4, 2023
View reviewed changes
simulators/ethereum/engine/Dockerfile
Comment on lines -4 to -8
RUN \
/usr/local/bin/geth makecache 1 /ethash && \
/usr/local/bin/geth makecache 30000 /ethash && \
/usr/local/bin/geth makedag 1 /ethash && \
/usr/local/bin/geth makedag 30000 /ethash
Copy link
Contributor

@holiman holiman May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can skip the line above too, and also L24 COPY --from=geth /ethash /ethash

Copy link
Contributor Author

@s1na s1na May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I forgot to push this. Thanks for fixing

holiman
holiman approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it can't be any less functional than current master. Might aswell get it merged IMO. Un-draft @s1na ?

@holiman
Copy link
Contributor

holiman commented May 4, 2023

The --fakepow flag is also removed. Now a merge-ready network is required and in that case a PoW fake verifier will be available. To trigger this we set "terminalTotalDifficultyPassed": true.

An alternative solution is to re-add the --fakepow flag. For example, we might have cases with invalid chains, due to invalid difficulty. We can still support that, because the fakepow mechanism still exists internally in geth, we just removed the flag.

Fakepow is basically ethash but without verifying the PoW nonce.

This PR will instead accept "invalid difficulty chain" due to the terminalTotalDifficultyPassed flag. Although, one might argue that failing those tests are correct, because geth is no longer able to function correctly without external guidance on canon header.

@s1na s1na marked this pull request as ready for review May 4, 2023 12:54
@s1na
Copy link
Contributor Author

s1na commented May 4, 2023

I still hadn't a chance to look at every simulation but un-drafted for now. This will at least fix CI for other PRs.

@s1na s1na merged commit 7e559b0 into ethereum:master May 4, 2023
@shekhirin shekhirin mentioned this pull request May 12, 2023
Merged
mattsse pushed a commit to paradigmxyz/hive that referenced this pull request May 12, 2023
@shekhirin @marioevz
@gfukushima @yperbasis @s1na @spencer-tb @holiman
Merge ethereum/hive/master (#26)
bbd52d3 
* simulators/ethereum/engine: send `eth_` requests to port 8545 (ethereum#752)

simulators/ethereum/engine: send `eth_` requests to 8545

* clients/ethereumjs: Update branch (ethereum#753)

* clients/ethereumjs: Change git branch

* clients/ethereumjs: Fix bash script issues

* simulators/ethereum/engine: node: unsubscribe from events

* simulators/ethereum/engine: clmock: add extra logs

* simulators/ethereum/engine: correctly stop secondary clients

* simulators/eth2/common: create client interfaces, update mock builder (ethereum#738)

* simulators/eth2/common: refactor clients

* simulators/eth2/engine: fixes due to refactor

* simulators/eth2/common: builder: invalidate payloads

* simulators/eth2/common: builder readme

* simulators/eth2/common: builder: add option to build a payload on an outdated version

* simulators/eth2/withdrawals: add invalid built payload version test

* simulators/eth2/common: builder: remove check to build invalid payload

* simulators/eth2/withdrawals: Fix check

* simulators/eth2/withdrawals: test case validation

* simulators/eth2/common: builder: fix invalidation

* simulators/eth2/withdrawals: fix verifications again

* simulators/ethereum/pyspec: Comment Dockerfile to run local fixtures (ethereum#755)

simulators/ethereum/pyspec: Add Dockerfile comment to run locally generated fixtures

* clients/besu: add --data-storage-format=BONSAI  (ethereum#758)

* simulators/ethereum/engine: Unique Payload ID Tests (ethereum#757)

* simulators/ethereum/engine: expose generic fcu, np

* simulators/ethereum/engine: Unique payload id test

* simulators/ethereum/engine: Add payload id test

* simulators/ethereum/engine: Parallel getPayloadBodies Test (ethereum#749)

* simulators/ethereum/engine: parallel getpayloadbodies

* simulators/ethereum/withdrawals: readme

* clients/erigon: --externalcl flag is not supported anymore (ethereum#760)

* graphql: consistent rule for Long outputs and args (ethereum#746)

* simulators/eth2: Verify block signatures on blocks sent to builder (ethereum#756)

* simulators/eth2/common/builder: interfaces changes

* simulators/eth2/common/builder: verify signatures

* simulators/eth2/withdrawals: Verify block signatures

* simulators/eth2/withdrawals: Update README

* simulators/eth2/withdrawals: minor nit comment

* clients/erigon: explicit --db.size.limit value (ethereum#766)

* clients/nethermind: Cancun support (ethereum#762)

* clients/nethermind: Cancun Support

* clients/nethermind: Dockerfile args

* clients/besu: Cancun Support (ethereum#769)

* clients/ethereumjs: Cancun Support (ethereum#768)

clients/ethereumjs: Cancun Support.

* clients/go-ethereum: remove deprecated PoW (ethereum#773)

Remove ethash-related flags and utils from go-ethereum, since they were
deprecated upstream.

---------

Co-authored-by: Martin Holst Swende <[email protected]>

* clients/nethermind: Add excessDataGas to genesis mapper. (ethereum#771)

* sim/pyspec: bubble error (ethereum#777)

* simulators/devp2p: fix issue causing ethereumjs to crash (ethereum#778)

sim/devp2p: fix issue causing ethereumjs to crash

It seems ethereumjs crashes if the chainid is not present in the genesis.

---------

Co-authored-by: Mario Vega <[email protected]>
Co-authored-by: Gabriel Fukushima <[email protected]>
Co-authored-by: Andrew Ashikhmin <[email protected]>
Co-authored-by: Sina Mahmoodi <[email protected]>
Co-authored-by: Spencer Taylor-Brown <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@barnabasbusa
feat: add resource configuration for prometheus and grafana (ethereum…
d296c26 
…#773)

Please note: 
`grafana_additional_dashboards` ->
`grafana_params.additional_dashboards`
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@EthPandaOpsBot
chore(main): release 4.4.0 (ethereum#774)
861cf2e 
🤖 I have created a release *beep* *boop*
---


##
[4.4.0](ethpandaops/ethereum-package@4.3.0...4.4.0)
(2024-11-01)


### Features

* add checkpoint sync capabilities to nimbus
([ethereum#804](ethpandaops/ethereum-package#804))
([853417e](ethpandaops/ethereum-package@853417e))
* add commit-boost support
([ethereum#779](ethpandaops/ethereum-package#779))
([ebbbe83](ethpandaops/ethereum-package@ebbbe83))
* add docker authentication
([ethereum#816](ethpandaops/ethereum-package#816))
([807f6aa](ethpandaops/ethereum-package@807f6aa))
* add peerdas metrics dashboard
([ethereum#790](ethpandaops/ethereum-package#790))
([12b787d](ethpandaops/ethereum-package@12b787d))
* add rbuilder remove old geth builder - flashbots
([ethereum#786](ethpandaops/ethereum-package#786))
([de95c61](ethpandaops/ethereum-package@de95c61))
* add resource configuration for prometheus and grafana
([ethereum#773](ethpandaops/ethereum-package#773))
([d296c26](ethpandaops/ethereum-package@d296c26))
* add supernode label to every container
([ethereum#788](ethpandaops/ethereum-package#788))
([43edfd5](ethpandaops/ethereum-package@43edfd5))
* add support for fulu/osaka fusaka
([ethereum#798](ethpandaops/ethereum-package#798))
([0a9e445](ethpandaops/ethereum-package@0a9e445))
* add support for remote signers - `use_remote_signer`
([ethereum#791](ethpandaops/ethereum-package#791))
([9f1b6e9](ethpandaops/ethereum-package@9f1b6e9))
* enable one parameter supernode, refactor el,cl,vc
([ethereum#778](ethpandaops/ethereum-package#778))
([8513c06](ethpandaops/ethereum-package@8513c06))


### Bug Fixes

* add database config to assertoor
([ethereum#783](ethpandaops/ethereum-package#783))
([56532cf](ethpandaops/ethereum-package@56532cf))
* add nimbus-eth1 net-key
([ethereum#811](ethpandaops/ethereum-package#811))
([c91bbbb](ethpandaops/ethereum-package@c91bbbb))
* delete unnecessary port assignment for prysm
([ethereum#810](ethpandaops/ethereum-package#810))
([47204c3](ethpandaops/ethereum-package@47204c3))
* docker login to separate action yaml
([ethereum#819](ethpandaops/ethereum-package#819))
([2494022](ethpandaops/ethereum-package@2494022))
* get volume size recommendations when in shadowfork mode
([ethereum#820](ethpandaops/ethereum-package#820))
([b1f27c6](ethpandaops/ethereum-package@b1f27c6))
* mixed up labels
([ethereum#799](ethpandaops/ethereum-package#799))
([e2c1528](ethpandaops/ethereum-package@e2c1528))
* only set supernode if its true
([ethereum#796](ethpandaops/ethereum-package#796))
([2110a60](ethpandaops/ethereum-package@2110a60))
* prefund container suffixes for k8s
([ethereum#818](ethpandaops/ethereum-package#818))
([968cfbd](ethpandaops/ethereum-package@968cfbd))
* remove deprecated http-allow-sync-stalled from LH
([ethereum#805](ethpandaops/ethereum-package#805))
([1825dbf](ethpandaops/ethereum-package@1825dbf))
* Remove not necessary "/api" (and bump verifier version)
([ethereum#792](ethpandaops/ethereum-package#792))
([befde97](ethpandaops/ethereum-package@befde97))
* set default for label-maker
([ethereum#797](ethpandaops/ethereum-package#797))
([5b2d234](ethpandaops/ethereum-package@5b2d234))
* swap http/grpc server ports and replace flags
([ethereum#802](ethpandaops/ethereum-package#802))
([8c6df26](ethpandaops/ethereum-package@8c6df26))
* update built in assertoor tests
([ethereum#782](ethpandaops/ethereum-package#782))
([d24fb2a](ethpandaops/ethereum-package@d24fb2a))
* update nethermind config option
([ethereum#824](ethpandaops/ethereum-package#824))
([08ce034](ethpandaops/ethereum-package@08ce034))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@holiman holiman holiman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s1na @holiman