Skip to content

Jg/p2p rewrite #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 94 commits into from
Closed

Jg/p2p rewrite #657

wants to merge 94 commits into from

Conversation

@trianglesphere
Copy link

@trianglesphere trianglesphere commented Nov 9, 2022

No description provided.

tuxcanfly and others added 30 commits September 8, 2022 16:13
@tuxcanfly @mslipper
hive: add optimism devnet simulator (#1)
d99a265 
A new simulator for optimism devnet is added. It requires
multiple optimism specific clients and their sequence is
significant. So the only way to invoke the devnet simulator
is to launch with the following clients:

hive --sim optimism  --client=ops-l1,ops-l2,ops-opnode,ops-l2os --docker.output

The current test suite is adapter from ethereum/rpc and modified to suit
the optimism devnet. Only a subset of the RPC tests are supported at
the moment but more will be added later. Other test suites may extend
the devnet in the future to extend test coverage.
@tuxcanfly @mslipper
simulator (optimism): fix l1 genesis timestamp (#3)
c690e2d 
* simulator (optimism): restore balance test

* simulator (optimism): restore contract deployment test
@tuxcanfly @mslipper
simulator (optimism): rm unnecessary sleep (#2)
02a7c30
@tuxcanfly @mslipper
simulator (op): add l2 genesis predeploy, restore all rpc tests (#5)
8b0eaa2 
* simulators (op): restore predeploy

* simulators (op): restore all rpc tests

* simulators (op): log - include tx hash in error
@tuxcanfly @mslipper
simulators (op): refactor - add bss client (#6)
e8f075f 
* simulators (op): refactor - add bss client

* clients (ops-l1): add batchsubmitter faucet

* clients (op): rename for new build

* simulators (op): update go mod
@tuxcanfly @mslipper
simulators (op): bump semaphore count
618d9d9
@tuxcanfly @mslipper
simulator (op): bump semaphore count
d7d68ff
@tuxcanfly @mslipper
simulators (op): l2 predeploy - new contracts
28a2629 
Added new L1 contract deployment bytecode to L2 predeploy genesis:

* L2ToL1MessagePasser (replaces Withdrawer)
* L2CrossDomainMessenger
* OptimismMintableTokenFactory
* L2StandardBridge
@tuxcanfly @mslipper
simulators (op): bump reference-optimistic-geth
dfead8d
@tuxcanfly @mslipper
simulators (op): bump go.sum
004ddaf
@tuxcanfly @mslipper
clients (op): optimistic-specs -> monorepo
e4a8971
@tuxcanfly @mslipper
op: update devnet; sync with monorepo
c1075ce
@tuxcanfly @mslipper
op: update to use proxy
369e447
@tuxcanfly @mslipper
op: devnet -> rpc
4033d19
@tuxcanfly @mslipper
clients (op): fix deploy - use proxy contracts
b44fc61
@tuxcanfly @mslipper
op: update circle config for op-tests
36002ae
@tuxcanfly @mslipper
ci: add slack alerts
d46989d
@tuxcanfly @mslipper
client (op-node): update flags
b0861b2
@tuxcanfly @mslipper
client (op-l1): use monorepo, fix missing npx
fe26c14
@tuxcanfly @mslipper
simulator (op/rpc): bump reference-optimistic-geth
2c3b871
@tuxcanfly @mslipper
client (op-batcher): rm --sequencer-genesis-hash
be32655
@tuxcanfly @mslipper
op-batcher: fix flags; update l2geth
2b9f1a2
@protolambda @mslipper
simulators/optimism/rpc: update dependencies
aef8cb8
@tuxcanfly @mslipper
op: refactor op-node to use dynamic hive.Params
15a934e
@tuxcanfly @mslipper
client(op-node): rm hardcoded ip addrs, ports
3f50d83
@tuxcanfly @mslipper
op: rm hardcoded IPs
1dcd5d3
@tuxcanfly @mslipper
pkg: optimism devnet
b50390c
@protolambda @mslipper
branch docker arg support
d4b5139
@tuxcanfly @mslipper
clients: move ARG after FROM
deef12d
@tuxcanfly @mslipper
simulator (optimism/p2p): add new simulator to test p2p (#15)
6e1e308 
* simulator (op): adds new simulator to test p2p

* ci: update test cmd; rename test

* op: rebase + refactor op-node

* go: module cleanup; update ci workflow

* op: go mod tidy

* op: devnet - add method StartVerifier

* op: devnet - pass required flags

* op: devnet - use p2p static flag in entrypoint

* op: devnet - update multiaddr

* simulator (optimism/p2p): verifier - static p2p

* ci: add parallel p2p / rpc workflows

* ci: fix workflows

* simulator (optimism/rpc): bump hive version

* simulators (optimism/rpc): bump go.sum

* op: devnet - pass dynamic p2p node key

* simulators (optimism/p2p): bump hive

* simulators (optimism/p2p): bump go.sum

* simulators (optimism/p2p): use str p2p node key

* simulators (optimism/p2p): bump hive
mslipper and others added 26 commits September 26, 2022 20:54
@mslipper
Hive: deploy contract via deposit (#45)
d263e17
@mslipper
Improve withdrawal reliability (#46)
56fa2d6 
The `--miner.gaslimit` flag was not being passed, which could lead to reorgs. I ran this 3 times locally, and all three executions passed.
@mslipper
Attempt to fix deposit/withdrawal tests (#48)
836abcc 
I narrowed this issue down to reverts during deposits. It seems like the default gas limit calculation under-estimates the limit sometimes which leads to deposits reverting without a reason. I'm not 100% sure why this is, but I have a hunch it's related to the `ResourceMetering` contract since specifying a high manual gas limit resolved the issue. I'll follow up with @tynes to dig deeper into whether this is correct, and understand the root cause.

To test this, I ran the tests 3 times against CI and got passes each time.

Fixes ENG-2726
@mslipper
Add simple ERC20 bindings (#49)
8cbb5d7 
This enables ERC20 deposit/withdrawal tests.
@mslipper
Add roundtrip ERC-20 test through the bridge (#50)
60183ad 
Includes a dependency upgrade so that these tests can take advantage of the updated logic in `ParseWithdrawal`.
@mslipper
Add failing deposit with mint tests (#51)
929c55f 
Tests two different kinds of failing deposits:

- Garbage data, end
- A call to a contract that reverts.
@mslipper
Add test for spending more gas on L2 than allotted on L1 (#52)
075c8d4 
* Add test for spending more gas on L2 than allotted on L1

Fixes ENG-2384

* Code review updates
@trianglesphere
Tx Forwarding test (#54)
3f7962f 
* Test tx forwarding

This test verifies that tx forwarding properly sends the transaction to
the sequencer.

It still has some remaining oddities:
- It could pass accidentally (not likely though) if no txpool gossip is not set
- The transaction is received by the sequencer EE, but it is not accepted
  into the L2 chain.

* Update build image to go 1.19

* Update circleCI image runner

I determined that the hive build step used GLIBC 2.32 but the previous
machine executor used GLIBC 2.32. GLIBC is not backwards compatible like this.
@marioevz @trianglesphere
clients/prysm-bn: Add enable-debug-rpc-endpoints (ethereum#651)
828b193
@marioevz @trianglesphere
simulator/ethereum/engine: Fix Transaction Already Known Issue (ether…
7a2778c 
…eum#634)
@trianglesphere
Remove op-contracts client from readmes (#53)
3a80ce8 
This client doesn't seem to exist anymore. This also added a new readme.
@mslipper
Merge pull request #55 from ethereum-optimism/jg/sync_fork
72a0888 
Pull in upstream changes
@trianglesphere
Fix gas fees of transactions
45134ff 
This was causing the transactions to not get mined on the sequencer
because the gas price was too low.
@trianglesphere
Merge pull request #56 from ethereum-optimism/jg/fix_p2p_test
e1a6ffb 
Fix gas fees of transactions
@mslipper
Add ALLOW_NON_FINALIZED to support new proposer
dbdb4ad
@mslipper
go mod tidy
566c01f
@mslipper
update dependencies, remove outdated testnet simulator (#57)
31aa644 
* update dependencies, remove outdated testnet simulator

* update tests
@protolambda
optimism: update setup and simulators to monorepo v0.10 releases
927ff05
@protolambda
optimism: import optimism module by git commit
197ebe0
@mslipper
bump seq drift
ba9a92c
@mslipper
Merge pull request #58 from ethereum-optimism/update-to-v0_10
0786a2d 
optimism: update to v0.10 modules
@tynes
hive: fix config for L2 genesis creation (#60)
61035c5
@trianglesphere
Remove require from non main go-routine (#61)
ba6cbca 
A failure in a `require` statement calls `t.FailNow` which was occuring
from the non main go-routine. This is not a correct usage of `require`.
@tynes
hive: add SystemConfig bindings (#59)
b560cd1
@trianglesphere
Logging
fc77936
@trianglesphere
Clean up p2p test
e39047c
@trianglesphere trianglesphere deleted the jg/p2p_rewrite branch November 10, 2022 17:34
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@barnabasbusa
feat: add prefunded accounts to output (ethereum#657)
bc06e2a
racytech pushed a commit to racytech/hive that referenced this pull request Apr 4, 2025
@github-actions
chore(main): release 3.1.0 (ethereum#594)
20fef70 
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](ethpandaops/ethereum-package@3.0.0...3.1.0)
(2024-06-07)


### Features

* add http url to el context
([ethereum#656](ethpandaops/ethereum-package#656))
([4e69a4c](ethpandaops/ethereum-package@4e69a4c))
* add prefunded accounts to output
([ethereum#657](ethpandaops/ethereum-package#657))
([bc06e2a](ethpandaops/ethereum-package@bc06e2a))
* add tracoor
([ethereum#651](ethpandaops/ethereum-package#651))
([b100cb6](ethpandaops/ethereum-package@b100cb6))
* add vc_count to increase the number of validators per participant
([ethereum#633](ethpandaops/ethereum-package#633))
([4272ff3](ethpandaops/ethereum-package@4272ff3))
* allow setting custom dora image & env variables
([ethereum#623](ethpandaops/ethereum-package#623))
([08a65c3](ethpandaops/ethereum-package@08a65c3))
* **apache:** Serve all config files
([ethereum#606](ethpandaops/ethereum-package#606))
([3f1f5e1](ethpandaops/ethereum-package@3f1f5e1))
* **config:** add peerdas vars
([ethereum#619](ethpandaops/ethereum-package#619))
([22f1498](ethpandaops/ethereum-package@22f1498))
* expose network-params
([ethereum#659](ethpandaops/ethereum-package#659))
([b0820dd](ethpandaops/ethereum-package@b0820dd))
* forky
([ethereum#625](ethpandaops/ethereum-package#625))
([ded68bd](ethpandaops/ethereum-package@ded68bd))
* Support participants_matrix
([ethereum#620](ethpandaops/ethereum-package#620))
([3a57467](ethpandaops/ethereum-package@3a57467))
* use `peer-das` image for dora when eip7594 is active
([ethereum#593](ethpandaops/ethereum-package#593))
([1b4bd3d](ethpandaops/ethereum-package@1b4bd3d))


### Bug Fixes

* add additional prefund addresses
([ethereum#655](ethpandaops/ethereum-package#655))
([6d2cdb6](ethpandaops/ethereum-package@6d2cdb6))
* add cl log level to builders
([ethereum#638](ethpandaops/ethereum-package#638))
([ad46dbd](ethpandaops/ethereum-package@ad46dbd))
* Add EIP-7002 & EIP-2935 bytecode to ethereum-genesis-generator
([ethereum#597](ethpandaops/ethereum-package#597))
([3d316ef](ethpandaops/ethereum-package@3d316ef))
* add http to teku endpoint
([ethereum#622](ethpandaops/ethereum-package#622))
([085b6e1](ethpandaops/ethereum-package@085b6e1))
* add peer_das_epoch to egg
([ethereum#603](ethpandaops/ethereum-package#603))
([91694df](ethpandaops/ethereum-package@91694df))
* add sha256 as an image label (if present)
([ethereum#637](ethpandaops/ethereum-package#637))
([3dcf888](ethpandaops/ethereum-package@3dcf888))
* add static port config for apache
([ethereum#608](ethpandaops/ethereum-package#608))
([b96e502](ethpandaops/ethereum-package@b96e502))
* **apache:** only set static port if wanted
([ethereum#610](ethpandaops/ethereum-package#610))
([2c6b7b1](ethpandaops/ethereum-package@2c6b7b1))
* blockscout fix for json variant
([ethereum#662](ethpandaops/ethereum-package#662))
([e79c510](ethpandaops/ethereum-package@e79c510))
* churn adjustments
([ethereum#614](ethpandaops/ethereum-package#614))
([12ca872](ethpandaops/ethereum-package@12ca872))
* default config
([ethereum#632](ethpandaops/ethereum-package#632))
([14be117](ethpandaops/ethereum-package@14be117))
* drop everythign after [@sha](https://github.com/sha) from image labels
([ethereum#636](ethpandaops/ethereum-package#636))
([5d35463](ethpandaops/ethereum-package@5d35463))
* erigon v3 - new default image
([ethereum#629](ethpandaops/ethereum-package#629))
([72cf150](ethpandaops/ethereum-package@72cf150))
* genesis generator bump
([ethereum#611](ethpandaops/ethereum-package#611))
([5460f6f](ethpandaops/ethereum-package@5460f6f))
* nightly tests
([ethereum#595](ethpandaops/ethereum-package#595))
([76c31e9](ethpandaops/ethereum-package@76c31e9))
* pectra example
([ethereum#605](ethpandaops/ethereum-package#605))
([67e3da0](ethpandaops/ethereum-package@67e3da0))
* prysm vc key manager ports
([ethereum#639](ethpandaops/ethereum-package#639))
([81c1ee7](ethpandaops/ethereum-package@81c1ee7))
* re-add images to labels
([ethereum#634](ethpandaops/ethereum-package#634))
([71f6e28](ethpandaops/ethereum-package@71f6e28))
* README has invalid configs
([ethereum#631](ethpandaops/ethereum-package#631))
([e33b971](ethpandaops/ethereum-package@e33b971))
* readme indentation
([ethereum#600](ethpandaops/ethereum-package#600))
([583db1b](ethpandaops/ethereum-package@583db1b))
* registration flags when using beacon node only
([ethereum#618](ethpandaops/ethereum-package#618))
([c12506b](ethpandaops/ethereum-package@c12506b))
* repair check workflow for external PRs
([ethereum#616](ethpandaops/ethereum-package#616))
([a584682](ethpandaops/ethereum-package@a584682))
* seperate vc service names
([ethereum#654](ethpandaops/ethereum-package#654))
([a5ffe14](ethpandaops/ethereum-package@a5ffe14))
* tune Besu options to work with tx_spammer
([ethereum#612](ethpandaops/ethereum-package#612))
([b395189](ethpandaops/ethereum-package@b395189))
* update dora images
([ethereum#598](ethpandaops/ethereum-package#598))
([dd28d61](ethpandaops/ethereum-package@dd28d61))
* update prysm image
([ethereum#599](ethpandaops/ethereum-package#599))
([0a38114](ethpandaops/ethereum-package@0a38114))
* use `electra-support` image for assertoor when electra fork epoch is
set
([ethereum#607](ethpandaops/ethereum-package#607))
([cdeab93](ethpandaops/ethereum-package@cdeab93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@trianglesphere @tuxcanfly @protolambda @mslipper @marioevz @tynes