eth/downloader: fix incorrect waitgroup in test XTestDelivery
#33047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wit765
changed the title
wg.Add(1) in test case XTestDeliverywg.Add(1) in test case XTestDelivery
rjl493456442
approved these changes
Oct 30, 2025
rjl493456442
changed the title
wg.Add(1) in test case XTestDeliveryXTestDelivery
wit765
added a commit
to wit765/XDPoSChain
that referenced
this pull request
Oct 30, 2025
19 tasks
ok4ko84-spec
added a commit
to ok4ko84-spec/go-ethereum
that referenced
this pull request
Oct 31, 2025
…y` (ethereum#33047)" This reverts commit 243407a.
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 6
wg.Done()and 5wg.Add (1)in the test caseXTestDelivery.