core/rawdb: improve the test suite for ancient store #32555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for catching it. Can you please also add the error handling around all |
Contributor
Author
Done |
rjl493456442
approved these changes
Sep 9, 2025
rjl493456442
changed the title
Sahil-4555
pushed a commit
to Sahil-4555/go-ethereum
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace TruncateTail(0) with TruncateHead(0) in basicWrite. TruncateTail only advances the tail (prunes prunable tables) and does not reset the head/items count, so it does not “truncate everything.” Using TruncateHead(0) properly clears the ancient store to an empty state, allowing re-appending from index 0 and aligning with existing tests and the documented semantics in ethdb.